[GROOVY-9122] code smell in ProcessingUnit

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-beta-1, 2.5.7
• Fix Version/s: 2.5.8, 3.0.0-beta-2
• Labels: breaking
• Assignee: Paul King
• Reporter: Paul King
• Created: 17/May/19 01:17
• Updated: 04/Apr/20 10:09
• Resolved: 17/May/19 03:33

Description

We have both configure and setConfiguration which by default do the same thing. The constructor only uses the former. It isn't clear which should be overridden if wanting to extend the class using normal OO conventions. We can make the setConfiguration method final to capture the intent of current usage.

The change is a breaking change if code was overriding setConfiguration but in that case it was probably broken to start with.