Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-9122

code smell in ProcessingUnit

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-beta-1, 2.5.7
    • Fix Version/s: 2.5.8, 3.0.0-beta-2
    • Component/s: None
    • Labels:

      Description

      We have both configure and setConfiguration which by default do the same thing. The constructor only uses the former. It isn't clear which should be overridden if wanting to extend the class using normal OO conventions. We can make the setConfiguration method final to capture the intent of current usage.

      The change is a breaking change if code was overriding setConfiguration but in that case it was probably broken to start with.

        Attachments

          Activity

            People

            • Assignee:
              paulk Paul King
              Reporter:
              paulk Paul King
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: