[GROOVY-9078] Inefficiency in MethodNode and ConstructorNode

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta-1, 2.5.7, 2.4.17
• Assignee: Paul King
• Reporter: Eric Milles
• Created: 11/Apr/19 20:53
• Updated: 20/May/19 07:31
• Resolved: 12/Apr/19 00:40

Description

The constructor of MethodNode performs VariableScope scope = new VariableScope(); setVariableScope(scope); followed by setParameters(parameters);, which in turn creates a variable scope, populates it and sets it. The first variable scope is superflous and those 2 lines could be deleted.

Also, the constructor of ConstructorNode calls the super constructor and then creates a variable scope, fills it with param info and sets it. Since the super constructor (as described above) already calls setParameters, the extra variable scope created in ConstructorNode could be removed.