[GROOVY-8562] Wrong Closure delegation for property access when using @CompileStatic and DELEGATE_FIRST / DELEGATE_ONLY

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.11, 2.6.0-alpha-3, 3.0.0-alpha-2, 2.5.0-rc-1, 2.4.15
• Fix Version/s: 2.5.0
• Component/s: Static compilation
• Assignee: Paul King
• Reporter: Michael Arndt
• Created: 27/Apr/18 15:16
• Updated: 26/Jul/18 04:38
• Resolved: 24/May/18 14:11

Description

Closures resolve to owner property although `DELEGATE_FIRST` or `DELEGATE_ONLY` are set as `resolveStrategy`.
This only happens when `@CompileStatic` is used.
This does not apply to method calls.
For Groovy 2.3.11 this only affects read operations.

Only the versions 2.5.0-rc-1, 2.4.15, 2.3.11 have been tested yet.
I will add tests for newer versions, but this requires a different test framework than Spock.

I have created a demo project at https://github.com/MeneDev/groovy-bugreport-closure-strategy

 

class ADelegate {
    def x = "delegate"
}

@CompileStatic
class AClass {
    public <T> T closureExecuter(
            ADelegate d,
            @DelegatesTo(value = ADelegate, strategy = DELEGATE_ONLY) Closure<T> c) {
        c.resolveStrategy = DELEGATE_ONLY
        c.delegate = d
        return c()
    }

    def x = "owner"
    
    def test() {
        def theDelegate = new ADelegate()
        def res = closureExecuter(theDelegate) {
            return x
        }
        
        // is "owner" instead of "delegate"
        return res
    }
}

Issue Links

• links to: GitHub Pull Request #717