[GROOVY-8100] MarkupBuilder cant yield before first tag - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.4.8, 3.0.0-rc-2
Fix Version/s: 4.0.0-alpha-1, 3.0.5
Component/s: XML Processing
Labels:
None
Environment:
Oracle Java 1.8.0_112, Windows 10 x64

Description

Trying to produce an HTML5 compliant !DOCTYPE before starting with the HTML-Elements. Without setting the private field 'state' to 2, the output does not show the yielded output.

def html = new groovy.xml.MarkupBuilder(new PrintWriter(System.out))
//html.state = 2
html.mkp.yieldUnescaped("<!DOCTYPE html>\n")
html.h1("Header")

I suggest fixing this by changing the yield-Method to not check the state before doing the output, so that we see some output when the initial state is still 0:

void yield(String value, boolean escaping) {
    if (state == 1) {
        state = 2;
        this.nodeIsEmpty = false;
        out.print(">");
    }
    // -- remove -- if (state == 2 || state == 3) {
    out.print(escaping ? escapeElementContent(value) : value);
    // -- remove -- }
}

Attachments

Activity

People

Assignee:: Daniel Sun

Reporter:: Jochen Eddelbuettel

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 27/Feb/17 16:26

Updated:: 23/Jul/20 14:16

Resolved:: 21/Jun/20 23:43

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

0.5h