[GROOVY-7902] collate() infinite loop with zeroed step

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.7
• Fix Version/s: 2.5.0-alpha-1
• Component/s: groovy-jdk, groovy-runtime
• Environment: Groovy Version: 2.4.7 JVM: 1.8.0_92 Vendor: Oracle Corporation OS: Mac OS X
• Assignee: Paul King
• Reporter: Felipe Mamud
• Created: 08/Aug/16 17:24
• Updated: 02/May/17 02:03
• Resolved: 10/Aug/16 08:02

Description

Fixing infinite loop in Iterable.collate method when step parameter is equals to zero.

Example:

[ 1, 2, 3 ].collate( 2, 0 )

The result is a infinite loop because the step parameter is used directly in the for increment: pos += step

In the fixing I assumed that the step parameter should be equals to size parameter, looks like in the collate(self, size, size, keepRemainder) overloaded method, with absence of step and I considered backward compatibility with negative steps.

PR opened in Github: https://github.com/apache/groovy/pull/378

Thks.
Felipe Mamud

Issue Links

• links to: GitHub Pull Request #378