[GROOVY-6895] MarkupTemplateEngine may silently swallow errors

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.3
• Fix Version/s: 2.3.4
• Component/s: Templating
• Assignee: Cédric Champeau
• Reporter: Cédric Champeau
• Created: 26/Jun/14 02:24
• Updated: 08/Jul/14 15:28
• Resolved: 26/Jun/14 02:25

Description

The following code in the BaseTemplate class may cause errors to be silently dropped:

public Writer writeTo(final Writer out) throws IOException {
        try {
            this.out = createWriter(out);
            run();
            return out;
        } finally {
            this.out.flush();
            this.out = null;
        }
    }

To avoid the problem, a null check should be added to the finally block.