[GROOVY-6692] trait's groovyProxy class doesn't dispatch String#toString()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0-beta-1
• Fix Version/s: 2.3.0-rc-1
• Component/s: Compiler

Environment

% groovy -v
Groovy Version: 2.2.0-rc-3 JVM: 1.8.0 Vendor: Oracle Corporation OS: Mac OS X
% java -version
java version "1.8.0"
Java(TM) SE Runtime Environment (build 1.8.0-b132)
Java HotSpot(TM) 64-Bit Server VM (build 25.0-b70, mixed mode)

• Assignee: Cédric Champeau
• Reporter: UEHARA Junji
• Created: 10/Apr/14 01:35
• Updated: 24/Apr/14 19:00
• Resolved: 16/Apr/14 06:59

Description

following code(attached):

class DynamicTraitTest extends GroovyTestCase {
  @groovy.transform.TypeChecked
  void testTraitTest() {
      def x = new String("hello") as Helloable
      x.hello()
      assert !(x instanceof String)
      assert x.toUpperCase() == "HELLO" // exptected
      assert x.toString() == "hello" // fails
  }
}

trait Helloable {
    void hello() { println "hello" }
}

generate following exception:

% groovy dynamictrait.groovy
groovy dynamictrait.groovy
.hello
E
Time: 0.13
There was 1 error:
1) testTraitTest(DynamicTraitTest)Assertion failed:

assert x.toString() == "hello" // fails
\ | | |
\ | | false
\ | String1_groovyProxy@24269709
\ String1_groovyProxy@24269709

at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:398)
at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:646)
at DynamicTraitTest.testTraitTest(dynamictrait.groovy:8)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:90)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:233)
at groovy.lang.MetaClassImpl.invokeStaticMethod(MetaClassImpl.java:1318)
at org.codehaus.groovy.runtime.InvokerHelper.invokeStaticMethod(InvokerHelper.java:927)
at org.codehaus.groovy.runtime.InvokerHelper.invokeStaticMethod(InvokerHelper.java:77)
at groovy.lang.GroovyShell.runJUnit3Test(GroovyShell.java:353)
at groovy.lang.GroovyShell.runScriptOrMainOrTestOrRunnable(GroovyShell.java:273)
at groovy.lang.GroovyShell.run(GroovyShell.java:502)
at groovy.lang.GroovyShell.run(GroovyShell.java:491)
at groovy.ui.GroovyMain.processOnce(GroovyMain.java:627)
at groovy.ui.GroovyMain.run(GroovyMain.java:379)
at groovy.ui.GroovyMain.process(GroovyMain.java:365)
at groovy.ui.GroovyMain.processArgs(GroovyMain.java:124)
at groovy.ui.GroovyMain.main(GroovyMain.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at org.codehaus.groovy.tools.GroovyStarter.rootLoader(GroovyStarter.java:106)
at org.codehaus.groovy.tools.GroovyStarter.main(GroovyStarter.java:128)

FAILURES!!!
Tests run: 1, Failures: 0, Errors: 1

I don't know precise behavior of above case, but metaClass.mixin works with this code:

class DynamicMixinTest extends GroovyTestCase {
  void testTraitTest() {
      String.metaClass.mixin Helloable
      def x = "hello".asType(Helloable)
      x.hello()
      assert !(x instanceof String)
      assert x.toUpperCase() == "HELLO" // exptected
      assert x.toString() == "hello" // fails
  }
}

class Helloable {
    void hello() { println "hello" }
}