[GROOVY-6548] groovysh: Import command is vulnerable and ugly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.3.0-beta-1
• Component/s: Groovysh
• Assignee: Cédric Champeau
• Reporter: Thibault Kruse
• Created: 02/Feb/14 08:05
• Updated: 05/Apr/14 00:00
• Resolved: 05/Feb/14 02:21

Description

to reproduce:

groovy:000> import java.awt.TextField
===> [import java.awt.TextField]
groovy:000> import java.awt.TextField;
===> [import java.awt.TextField, import java.awt.TextField;]

should be just one time textfield

groovy:000> import java.awt.TextField; println('foo')
===> [import java.awt.TextField; println('foo')]
groovy:000> 2+2
foo
===> 4

should be prevented

Also the output of the list of imports is unnecessarily verbose, the "import " prefix does not add information, it just takes away screen space. Ideally this would even reduce package names to one letter, but this is bothersome to parse, given the variants of the import command