[GROOVY-6341] @CompileStatic + @Canonical + integer property == null pointer in hashcode

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.6
• Fix Version/s: 2.2.0-rc-3
• Component/s: Static compilation, xforms
• Assignee: Paul King
• Reporter: Jon Barksdale
• Created: 12/Sep/13 13:44
• Updated: 15/Oct/15 18:19
• Resolved: 06/Dec/13 15:30

Description

Using the @CompileStatic annotation with @Canonical, and having an integer property creates a null pointer opportunity in the generated hashCode method -

it decompiles to this:

public int hashCode()
{
int _result = HashCodeHelper.initHash();
int _tmp = _result;
if(!DefaultGroovyMethods.is(getName(), this))

{ int i = HashCodeHelper.updateHash(_result, getName()); _result = i; int _tmp1 = i; }

if(!DefaultGroovyMethods.is(getSomeNum(), this))

{ int j = HashCodeHelper.updateHash(_result, getSomeNum().intValue()); _result = j; int _tmp2 = j; }

return _result;
}

Note the intValue being called without checking to see if the getter returns null.