[GROOVY-5936] java.lang.OutOfMemoryError through Iterator.collectEntries and others (part 2: handle others)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.4
• Fix Version/s: 2.5.0-alpha-1
• Component/s: groovy-jdk
• Assignee: Paul King
• Reporter: Alexander Veit
• Created: 21/Jan/13 05:31
• Updated: 02/May/17 02:03
• Resolved: 04/Aug/16 05:40

Description

DGM.collectEntries(Iterator, ...) naively calls toList(Iterator<T> self) to convert the Iterator to a list. There's no need to do this since iterator suffices to collect the entries. Even worse, toList uses ArrayList what may lead to multiple reallocations when the ArrayList's capacity must be enlarged.

Error:
Caught: java.lang.OutOfMemoryError: GC overhead limit exceeded

The same problems may occur when calling other methods that internally convert Iterator to lists.

Issue Links

• is related to: GROOVY-5934 java.lang.OutOfMemoryError through Iterator.collectEntries and others (part 1: handle collectEntries)