[GROOVY-5927] JsonBuilder.toPrettyString() incorrect for zero-length String

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0-rc-1
• Fix Version/s: 2.1.0-rc-2, 2.1.0, 2.0.7
• Component/s: groovy-jdk
• Environment: > groovy --version; Groovy Version: 2.1.0-rc-1 JVM: 1.7.0_09 Vendor: Oracle Corporation OS: Windows 7
• Assignee: Paul King
• Reporter: Alan Thompson
• Created: 17/Jan/13 13:10
• Updated: 18/Jan/13 16:06
• Resolved: 17/Jan/13 23:42

Description

JsonBuilder.toString() works correctly for both zero-length and longer strings. JsonBuilder.toPrettyString() incorrectly inserts a pair of escaped double-quotes into the output for zero-length strings.

Consider the following test case:

import groovy.json.*
import groovy.util.GroovyTestCase
class MyTest extends GroovyTestCase {
  void testStringZero() {
    def m = [ s3:'abc', s0:'' ]
    def json = new JsonBuilder( m )
    def str = json.toString()
    def pretty = json.toPrettyString()
    def prettyTrim = pretty.replaceAll( ~/\s/, '' )

    if ( false ) {
      println ''
      println 'm: '           + m
      println 'str: '         + str
      println 'pretty: '      + pretty
      println 'prettyTrim: '  + prettyTrim
    }

    assert str == prettyTrim
  }
}

Enabling the prints produces:

m: [s3:abc, s0:]
str: {"s3":"abc","s0":""}
pretty: {
    "s3": "abc",
    "s0": "\"\""
}
prettyTrim: {"s3":"abc","s0":"\"\""}

E
Time: 0.165
There was 1 error:
1) testStringZero(MyTest)Assertion failed:

assert str == prettyTrim
       |   |  |
       |   |  {"s3":"abc","s0":"\"\""}
       |   false
       {"s3":"abc","s0":""}