[GROOVY-5826] wasted work in "DomToGroovy.mixedContent"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 29/Nov/12 10:08
• Updated: 05/Apr/15 14:43
• Resolved: 30/Nov/12 12:38

Description

The problem appears in Groovy 2.0.5 and in revision 740ae7c.. I
attached a one-line patch (patch.diff) that fixes it.

In method "DomToGroovy.mixedContent", the loop over "list" should
break immediately after "hasText" and "hasElement" are "true". All
the iterations after "hasText" and "hasElement" are "true" do not
perform any useful work, at best they just set "hasText" and
"hasElement" again to "true".

Method "addMethods" in class "EnumVisitor" has a similar loop (over
"methods"), and this loop breaks immediately after both "hasNext" and
"hasPrevious" are set to "true", just like in the proposed patch.

Similarly, method "rootLoader" in class "GroovyStarter" has a loop
that breaks when all three "hadMain" and "hadConf" and "hadCP" are set
to "true", like in the proposed patch.