[GROOVY-5803] wasted work in "ClassNode.addMixin"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6, 2.1.0-beta-1, 1.8.9
• Flags: Patch
• Assignee: Paul King
• Reporter: Adrian Nistor
• Created: 16/Nov/12 14:42
• Updated: 05/Apr/15 14:44
• Resolved: 17/Nov/12 18:09

Description

The problem appears in Groovy 2.0.5 and in revision 9c9cd23.. I
attached a one-line patch (addMixin.diff) that fixes it.

In method "ClassNode.addMixin", the loop over "mixins" should call
"break" immediately after "skip" is set to "true". All the iterations
after "skip" is set to "true" do not perform any useful work, at best
they just set "skip" again to "true".

"ClassNode.addInterface" has a similar problem. I attached a second
patch for it (addInterface.diff).