[GROOVY-5709] improve Grapes error reporting for ZipException

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.0.1, 2.0.2
• Fix Version/s: 2.2.0-beta-1
• Component/s: Grape
• Assignee: Pascal Schumacher
• Reporter: lucas
• Created: 17/Sep/12 15:19
• Updated: 20/Aug/13 03:21
• Resolved: 04/Feb/13 12:48

Description

Original text:"""
We have several ad hoc executable scripts that handle dependencies via Grapes and they all fail in this same particular way with any version of groovy > 2.0.0. 1.8.x does just fine. I've attached the execution of the script and the resulting output - using verbose grapes output.

The artifact itself doesn't seem to have any problems.

Preparing to download artifact org.mortbay.jetty#servlet-api-2.5;6.1.2!servlet-api-2.5.jar
Caught: BUG! exception in phase 'conversion' in source unit '/Users/lgray/Documents/projects/ni/scripts/tools-audience-extension/elasticsearch/audience/delete/nonindexed/DeleteNonindexedElasticsearchAudiences.groovy' error in opening zip file
BUG! exception in phase 'conversion' in source unit '/Users/lgray/Documents/projects/ni/scripts/tools-audience-extension/elasticsearch/audience/delete/nonindexed/DeleteNonindexedElasticsearchAudiences.groovy' error in opening zip file
Caused by: java.util.zip.ZipException: error in opening zip file
"""
The exception message above is almost useless. Even if there is a ZipException it should imho not cause a GroovyBugException. Grape should try to handle the exception and give a meaningfull error report.