[GROOVY-5146] Disallow setting of type on VariableExpression if isClosureSharedVariable() returns true from AST transforms

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.4
• Fix Version/s: 1.8.5, 2.0-beta-2
• Assignee: Cédric Champeau
• Reporter: Graeme Rocher
• Created: 25/Nov/11 02:46
• Updated: 24/Dec/11 03:08
• Resolved: 25/Nov/11 09:57

Description

If you set the type of a shared closure variable to something else then this leads to a VerifierError such as:

Caused by: java.lang.VerifyError: (class: org/example/BookController, method: test signature: ()Ljava/lang/Object;) Incompatible argument to function
	at java.lang.Class.getDeclaredFields0(Native Method)
	at java.lang.Class.privateGetDeclaredFields(Class.java:2291)
	at java.lang.Class.getDeclaredFields(Class.java:1743)

This is because the Groovy is expecting a Reference but gets the new type that was set in an AST transform. Either a better error needs to be produced or you should not be allowed to set the type of a Reference to avoid painful debugging experience for users.