[GROOVY-5056] ?TreeSet? Comparators not correctly comparing everything - Compares only a subset

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.2
• Fix Version/s: 1.9-beta-4, 1.8.4
• Assignee: Roshan Dawrani
• Reporter: Jason Griffith
• Created: 29/Sep/11 23:11
• Updated: 02/Nov/11 15:34
• Resolved: 01/Oct/11 08:16

Description

Hi everyone

This fails with the latest 1.8.3 snapshot - But works in 1.7.10

import java.util.logging.Logger;
import org.junit.*;

class Breaker {
   static Logger log = Logger.getLogger(getName())
   
   @Test
   void testBreaking() {
      def comparator = [compare:
         {a,b-> 
            def retVal = a.x.compareTo(b.x)
            log.info("Comparing ${a.x} to ${b.x} and returning ${retVal}")
            return retVal }
      ] as Comparator
   
      def ts1 = new TreeSet(comparator)
      ts1.addAll([
         new ToCompare(x:"1"),
         new ToCompare(x:"2"),
         new ToCompare(x:"3")
      ])
       
      def ts2 = new TreeSet(comparator)
      ts2.addAll([
         new ToCompare(x:"1"),
         new ToCompare(x:"2"),
         new ToCompare(x:"3")
      ])
      
      def difference = ts1 - ts2
      assert difference.size() == 0
   }
}

class ToCompare {
   String x
}

The test works if you pass the same list of the same objects to ts1 and ts2. Passing in different objects with the same content fails.

For 1.8.x, the logs spit out:

Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 2 to 1 and returning 1
Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 1 and returning 2
Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 2 and returning 1
Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 2 to 1 and returning 1
Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 1 and returning 2
Sep 29, 2011 9:03:57 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 2 and returning 1

For 1.7.10, the logs spit out:

Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 2 to 1 and returning 1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 1 and returning 2
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 2 and returning 1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 2 to 1 and returning 1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 1 and returning 2
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 2 and returning 1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 1 to 2 and returning -1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 1 to 1 and returning 0
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 2 to 2 and returning 0
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 2 and returning 1
Sep 29, 2011 9:07:09 PM sun.reflect.NativeMethodAccessorImpl invoke0
INFO: Comparing 3 to 3 and returning 0

Please let me know if there's anything else ya'll need!

Cheers
Jason Griffith