[GROOVY-5027] Groovydoc calculateFirstSentence doesn't recognise html tags as breaks

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.8.2, 1.9-beta-3
• Fix Version/s: 1.8.3, 1.9-beta-4
• Component/s: GroovyDoc
• Flags: Patch
• Assignee: Guillaume Sauthier
• Reporter: Tim Yates
• Created: 16/Sep/11 04:29
• Updated: 05/Apr/15 14:44
• Resolved: 22/Sep/11 10:00

Description

The Method summary block of the groovydoc pages contains a sentence describing the method.

However, if the javadoc looks like (taken from StreamingJsonBuilder.groovy):

    /**
     * Varargs elements as arguments to the JSON builder create a root JSON array
     * <p>
     * Example:
     * <pre class="groovyTestCase">
     * new StringWriter().with { w ->
     *   def json = new groovy.json.StreamingJsonBuilder( w )
     *   def result = json 1, 2, 3
     *
     *   assert result instanceof List
     *   assert w.toString() == "[1,2,3]"
     * }
     * </pre>
     * @param args an array of values
     * @return a list of values
     */

Then the summary text becomes:

Varargs elements as arguments to the JSON builder create a root JSON array

Example:

 new StringWriter().with { w ->
   def json = new groovy.json.StreamingJsonBuilder( w )
   def result = json 1, 2, 3

In this case, it is only confusing (as the assert is missed off the end, but in other cases, it could result in invalid code being shown in the summary.

The attached patch adds another replaceAll to the calculateFirstSentence method of SimpleGroovyDoc.java which trims the javadoc as soon as an HTML tag is encountered as the first thing on a new line in the javadoc.

The summary text for this same method then becomes simply:

Varargs elements as arguments to the JSON builder create a root JSON array