Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.0
-
Fix Version/s: 1.8.5, 2.0-beta-2
-
Component/s: None
-
Labels:None
-
Environment:Mac OSX 10.7, jdk 1.6.0_26-b03-383-11A511
Description
When running this code, I get the attached error. Please see: http://pastie.org/2327875. Dropping back to 1.7 seems to work. I'm running 1.8.1, but the problem also exists in 1.8.0.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Here is a shorter piece of code that reproduces it:
char[] c1 = 'xy'.toCharArray() getIndex(c1[0]) /* //Note: This works fine char a = 'a' getIndex(a) */ def getIndex(char base) {}
Corrected the bug title a bit.
Here is the shorter version of the code that currently reproduces the bug. (Probably the shorter version supplied earlier resulted in a VerifyError due to some other reason, and that piece of code works now.)
class ParalinearTest {
static void main(args){}
void zeroMatrix(int[][] matrix) {
matrix[0][0]
}
}
The bug can be seen in action on Groovy Web Console here: http://groovyconsole.appspot.com/edit/597001
The VerifyError is caused by how multi-dimensional arrays are handled on the fast-path.
For "int[][] matrix", matrix[0][0] is written in the class like:
BytecodeInterface8.intArrayGet(BytecodeInterface8.objectArrayGet(matrix, 0), 0)
when it should have been written as:
BytecodeInterface8.intArrayGet((int[])ScriptBytecodeAdapter.castToType(BytecodeInterface8.objectArrayGet(matrix, 0), int[]), 0)
The result of BytecodeInterface8.objectArrayGet was not casted to int[], which made the BytecodeInterface8.intArrayGet() call invalid.
The following patch solves the issue (tested locally with the latest shorter version and the original testcase of the bug):
@@ -166,11 +166,15 @@ public class BinaryExpressionMultiTypeDispatcher extends BinaryExpressionHelper leftExp.visit(acg); os.doGroovyCast(leftTypeOrig); rightExp.visit(acg); os.doGroovyCast(int_TYPE); bew.arrayGet(operation, false); - os.replace(leftType,2); + if(bew instanceof BinaryObjectExpressionHelper) { + os.replace(ClassHelper.OBJECT_TYPE,2); + } else { + os.replace(leftType,2); + } } else { super.evaluateBinaryExpression(message, binExp); } } else { int operationType = getOperandConversionType(leftType,rightType);
Well spotted Roshan! If that patch works with a 3d and 4d array too, then it would be nice of you to commit it. But I think it will work
Extended the test to cover 3d, 4d arrays also. They also work now.
Sorry, this error is not present in 1.8.0, I forgot to recompile after changing the gdk. It does remain in 1.8.1, however.