[GROOVY-4947] Little improvement in code generated for equals() by @EqualsAndHashCode ast transformation

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.8.2, 1.9-beta-3
• Flags: Patch
• Assignee: Roshan Dawrani
• Reporter: Roshan Dawrani
• Created: 26/Jul/11 10:39
• Updated: 05/Apr/15 14:44
• Resolved: 26/Jul/11 13:35

Description

Currently, equals() generated by @EqualsAndHashCode looks like

class C {
      String a, b
      boolean equals(Object other) {
              ...
              ...
              if(!(other instanceof C)) {return false}
              if(this.a != other.a) {...}
              if(this.b != other.b) {...}
              ...
      }
}

It access getters/fields of enclosing class using type Object, which is not ideal and creates a little issue for static analysis done by Groovy++.

A slightly better implementation could be:

class C {
      String a, b
      boolean equals(Object other) {
              ...
              ...
              if(!(other instanceof C)) {return false}
              C another = (C) other
              if(this.a != another.a) {...}
              if(this.b != another.b) {...}
              ...
      }
}

The patch attach has been reviewed on the "dev" mailing list.