Groovy
  1. Groovy
  2. GROOVY-4912

Make the createLoggingStrategy method protected, otherwise LogASTTransformation is not extensible

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.8.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Activity

      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      549d 5h 1m 1 Jochen Theodorou 04/Jan/13 08:33
      Resolved Resolved Closed Closed
      8d 12h 6m 1 Paul King 12/Jan/13 20:40
      Mark Thomas made changes -
      Workflow jira [ 12971192 ] Default workflow, editable Closed status [ 12978959 ]
      Mark Thomas made changes -
      Project Import Mon Apr 06 02:11:23 UTC 2015 [ 1428286283443 ]
      Mark Thomas made changes -
      Workflow jira [ 12733839 ] Default workflow, editable Closed status [ 12745486 ]
      Mark Thomas made changes -
      Project Import Sun Apr 05 13:32:57 UTC 2015 [ 1428240777691 ]
      Paul King made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Jochen Theodorou made changes -
      Field Original Value New Value
      Assignee blackdrag blackdrag [ blackdrag ]
      Status Open [ 1 ] Resolved [ 5 ]
      Resolution Won't Fix [ 2 ]
      Hide
      Pascal Schumacher added a comment -

      Should this issue be closed?

      Show
      Pascal Schumacher added a comment - Should this issue be closed?
      Hide
      Jochen Theodorou added a comment -

      LogASTTransformation is not designed to be extensible. Instead you are supposed to use an annotation, that provides its logging strategy as class value to the log setting and by implementing LogASTTransformation.LoggingStrategy. This class is then used by createLoggingStrategy to create the strategy. An example for that is the Log4j annotation in the same package as LogASTTransformation.

      Can you explain a little what kind of extension you have in mind?

      Show
      Jochen Theodorou added a comment - LogASTTransformation is not designed to be extensible. Instead you are supposed to use an annotation, that provides its logging strategy as class value to the log setting and by implementing LogASTTransformation.LoggingStrategy. This class is then used by createLoggingStrategy to create the strategy. An example for that is the Log4j annotation in the same package as LogASTTransformation. Can you explain a little what kind of extension you have in mind?
      Graeme Rocher created issue -

        People

        • Assignee:
          Jochen Theodorou
          Reporter:
          Graeme Rocher
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development