[GROOVY-4175] GroovyScriptEngine - loading non file based scripts does not work - isSourceNewer

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0, 1.7.1, 1.7.2
• Fix Version/s: 1.7.4, 1.8-beta-1
• Component/s: GroovyScriptEngine
• Assignee: Guillaume Sauthier
• Reporter: Arno Töll
• Created: 20/Apr/10 02:55
• Updated: 03/Aug/10 22:23
• Resolved: 21/Jul/10 07:35

Description

GroovyScriptEngine

In case of using a custom ResourceConnector the provided resource might not be a file resource (within GroovyClassLoader there is similar code (isSourceNewer) already respecting non file base resources)

 protected boolean isSourceNewer(ScriptCacheEntry entry) throws ResourceException  {
        if (entry==null) return true;
        long time = System.currentTimeMillis();
        
        for (String scriptName:entry.dependencies) {
            ScriptCacheEntry depEntry = scriptCache.get(scriptName);
            long entryChangeTime = depEntry.lastModified + config.getMinimumRecompilationInterval();
            if (entryChangeTime>time) continue;

            URLConnection conn = rc.getResourceConnection(scriptName);
            URL source = conn.getURL();
-->         String path = source.getPath().replace('/', File.separatorChar).replace('|', ':');
-->         File file = new File(path);
            long lastMod = file.lastModified();

            if (entryChangeTime > lastMod) {
                ScriptCacheEntry newEntry = new ScriptCacheEntry(depEntry.scriptClass,time,depEntry.dependencies);
                scriptCache.put(scriptName,newEntry);
                continue;
            }
            return true;
        }
        
        return false;
    }

Issue Links

• is related to: GROOVY-4288 GroovyScriptEngine can't refresh class from url other than file