[GROOVY-4069] Custom constructors added via metaclass are sometimes not cleaned up

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 1.7.2, 1.8-beta-1
• Assignee: Roshan Dawrani
• Reporter: Luke Daley
• Created: 20/Feb/10 18:49
• Updated: 07/Apr/10 23:45
• Resolved: 02/Mar/10 20:36

Description

There seems to be an issue with constructors added via metaclass and cleanup:

class MetaClassMagicTests extends GroovyTestCase {
    void testIt() {
        ExpandoMetaClass.enableGlobally()
        
        // Child.metaClass // uncomment and everything works
        
        // Save the old meta class
        def oldMetaClass = Parent.metaClass
        
        // Install a new one
        def emc = new ExpandoMetaClass(Parent, true, true)
        emc.initialize()
        GroovySystem.metaClassRegistry.setMetaClass(Parent, emc)
        
        // Install a map based constructor
        emc.constructor = { Map m -> Parent.newInstance() }
        
        // Parent constructor is used, all good
        assert new Child([:]) instanceof Parent
        
        // Reinstate the old meta class
        GroovySystem.metaClassRegistry.removeMetaClass(Parent) 
        GroovySystem.metaClassRegistry.setMetaClass(Parent, oldMetaClass)

        // This fails, this calls the custom constructor from above and returns an instance of Parent
        assert new Child([:]) instanceof Child
    }
    
}

class Parent { def a }
class Child extends Parent { def b }