Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-4034

Mixin's getClass() method replaces original getClass() implementation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.7
    • Fix Version/s: 1.6.9
    • Component/s: None
    • Labels:
      None

      Description

      class M {
          def doIt() {
              assert metaClass.owner.class == M // passes but shouldn't, should be T
          }
      }
      
      class T {}
      T.mixin(M)
      new T().doIt()
      

        Activity

        Hide
        roshandawrani Roshan Dawrani added a comment -

        Back-ported the fix.

        Show
        roshandawrani Roshan Dawrani added a comment - Back-ported the fix.
        Hide
        Guillaume Guillaume Delcroix added a comment -

        Yes, you can port it to 1.6 too.
        I'm not yet 100% sure we'll do another 1.6.x, but till we don't do an 1.8, we should still port critical bug fixes to 1.6 at least.

        Show
        Guillaume Guillaume Delcroix added a comment - Yes, you can port it to 1.6 too. I'm not yet 100% sure we'll do another 1.6.x, but till we don't do an 1.8, we should still port critical bug fixes to 1.6 at least.
        Hide
        roshandawrani Roshan Dawrani added a comment -

        Guillaume / Jochen, does this issue look worth porting to 1.6.9?

        The issue is not there on 1.7.x and trunk.

        Show
        roshandawrani Roshan Dawrani added a comment - Guillaume / Jochen, does this issue look worth porting to 1.6.9? The issue is not there on 1.7.x and trunk.
        Hide
        roshandawrani Roshan Dawrani added a comment - - edited

        This issue is not there on 1.7 onwards (http://groovyconsole.appspot.com/script/76002).

        How about upgrading to 1.7.x instead of getting it fixed on 1.6.9 and upgrading to that (assuming that you need the fix and can upgrade for that )?

        Show
        roshandawrani Roshan Dawrani added a comment - - edited This issue is not there on 1.7 onwards ( http://groovyconsole.appspot.com/script/76002 ). How about upgrading to 1.7.x instead of getting it fixed on 1.6.9 and upgrading to that (assuming that you need the fix and can upgrade for that )?

          People

          • Assignee:
            roshandawrani Roshan Dawrani
            Reporter:
            ldaley Luke Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development