[GROOVY-3733] splitEachLine

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7-beta-1
• Fix Version/s: 1.6.5, 1.7.1
• Component/s: groovy-jdk
• Assignee: Paul King
• Reporter: Joshua Frankamp
• Created: 10/Sep/09 18:36
• Updated: 07/Apr/15 19:13
• Resolved: 04/Jan/10 14:35

Description

http://groovy.codehaus.org/groovy-jdk/java/lang/String.html#splitEachLine%28java.lang.String%20sep,%20groovy.lang.Closure%20closure%29
javadoc string says:

"Iterates through the given String line by line, splitting each line using the given separator. The list of tokens for each line is then passed to the given closure."

This is flat wrong, it splits the string using a regex match using the argument as a regular expression pattern. Its a major bug because it is bad documentation (as the old saying goes, is worse than no documentation), and it cost me an hour or two.

The argument should be called regex, not sep, because it is a regular expression, NOT a separator as tokenize uses.

This is related to GROOVY-3694, but I think this deserves its own bug because it is a separate issue.

Issue Links

• is related to: GROOVY-3694 Consistent parameter names for DGM regex methods