[GROOVY-3668] Groovy compiler on Google App Engine thinks it is facing Java 1.4 (and therefore annotations don't work)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.4, 1.7-beta-1
• Fix Version/s: 1.6.5, 1.7-beta-2
• Component/s: Compiler
• Assignee: Peter Niederwieser
• Reporter: Peter Niederwieser
• Created: 09/Aug/09 20:22
• Updated: 15/Oct/09 17:15
• Resolved: 29/Aug/09 09:45

Description

Annotations are not present in classes compiled by the Groovy compiler running on App Engine. This is because the Java version check in VMPluginFactory doesn't work on App Engine, because ClassLoader.getSystemClassLoader() returns null there. Therefore I propose to change ClassLoader.getSystemClassLoader().loadClass(JDK5_CLASSNAME_CHECK) to VMPluginFactory.class.getClassLoader().loadClass(JDK5_CLASSNAME_CHECK). The new check is equally safe and also works on App Engine. If there are no objections, I will commit this change.
Speaking of version checks, it might be a good idea to introduce (or even copy) something like Spring's JdkVersion class into the Groovy codebase. The Spring folks know very well how to handle such stuff.