[GROOVY-3135] Incorrect array type created when calling vararg method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.6
• Fix Version/s: 1.6-rc-1, 1.5.8, 1.7-beta-1
• Environment: using groovy via gmaven-runtime-default 1.0-rc-3
• Assignee: Roshan Dawrani
• Reporter: Peter A Royal Jr.
• Created: 06/Nov/08 23:28
• Updated: 23/Dec/08 05:58
• Resolved: 06/Dec/08 07:55

Description

I have a constructor:

Foo( String foo, long bar, double... values )

in groovy, i am calling it with a String, a Long, and an Integer.

ParameterTypes.fitToVarArgs correctly determines that the array is a Double.

however, when MetaClassHelper.makeArray is called, it does:

        Class baseClass = secondary;
        if (obj != null) {
            baseClass = obj.getClass();
        }

which overrides the Double.class that is secondary, with Integer.class from the incoming value.

The constructor invocation then fails since the correct type was not passed.