[GROOVY-3085] Performance regression with MarkupBuilder in 1.6 beta 2

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6-beta-2
• Fix Version/s: 1.6-rc-1, 1.7-beta-1
• Environment: Ubuntu AMD64 Intel Dual Core 2.4GHz 4Gb RAM . Java 1.6.10 rc 2. Problem occurs both inside IntelliJ IDEA 7.04, and with Ant.
• Assignee: Alex Tkachman
• Reporter: Nigel Charman
• Created: 12/Oct/08 03:17
• Updated: 23/Dec/08 16:56
• Resolved: 21/Dec/08 13:12

Description

Approx time to run script below:

Groovy 1.5.6 800 ms
Groovy 1.6 beta1 500 ms
Groovy 1.6 beta2 1300 ms

import groovy.xml.MarkupBuilder

class Formatter {
    void formatAsXml(Writer writer) {
        def builder = new MarkupBuilder(writer)

        builder.Bookings {
            Booking {
                Origin("Auckland")
                Destination("Wellington")
                PassengerName("Mr John Smith")
            }
            Payment {
                From("J Smith")
                Amount(42)
            }
        }
    }
}

long start = System.currentTimeMillis()
def formatter = new Formatter()
def writer
1000.times({
    writer = new StringWriter()
    formatter.formatAsXml(writer)
})
println "Took ${System.currentTimeMillis() - start} millis"

Most of the extra time seems to be in the MarkupBuilder. Replacing formatAsXml() with the following code results in beta 2 being around 10-20% slower than beta 1 (which is within experimental error).

    void formatAsXml(Writer writer) {
        (1..1000).each {
            writer.write(it)
        }
    }