[GROOVY-2749] eachLine and splitEachLine work without encoding

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.5
• Fix Version/s: 1.5.6, 1.6-beta-1
• Assignee: Paul King
• Reporter: Jochen Theodorou
• Created: 14/Apr/08 06:03
• Updated: 16/Jun/08 16:25
• Resolved: 16/Apr/08 17:07

Description

several methods where added named eachLine and splitEachLine. But on InputStream no encoding is given, thus a InputStreamReader created there uses the default encoding, which might be wrong in many case. I personally would add the methods with the encoding variant and remove the ones without encoding for InputStream and URL. not using an encoding makes sense for String, because the encoding is already done then, in fact using an ecoding there could be seen as wrong. But not using an encoding on InputStream is wrong too. It is not portable and will kick you later. This means:

eachLine:

InputStream.eachLine(Closure) --> should be removed
InputStream.eachLine(String encoding, Closure) --> should be added
URL.eachLine(Closure) --> should be removed
URL.eachLine(String encoding, Closure) --> could be added, but I would prefer:
URL.toInputStream() ---> I prefer that, because then eachLine from InputStream can be used

splitEachLine:

InputStream.splitEachLine(String sep, Closure closure) --> should be removed
InputStream.splitEachLine(String encoding, String sep, Closure closure) --> should be added
URL.splitEachLine(String sep, Closure closure) --> should be removed
URL.splitEachLine(String encoding, String sep, Closure closure) --> could be added, again I prefer URL.toInputStream().. or URL.input

then all these each method should not return void, instead they should return what the closure returns the last time it was called. This allows writing a collecting closure which has to be added.. something like this

class Collector extends Closure {
  def closure
  def values = []
  def doCall(Object[] args) {
    if (closure!=null) closure(*args)
    values << args
    return values
  }
}