Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-2646

changed behaviour of isImplicitThis() in MethodCallExpression

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.6-beta-1
    • Fix Version/s: 1.5.6, 1.6-beta-1
    • Component/s: ast builder
    • Labels:
      None
    • Flags:
      Patch

      Description

      The method isImplicitThis() in MethodCallExpression has changed its behaviour. At least after compilation phase SEMANTIC_ANALYSIS. After phase CONVERSION the behaviour would have been as expected.

      Expected return values:

      • anObj.methodCall() isImplicitThis() returns false
      • this.println("anything") isImplicitThis() returns false
      • println("anything") isImplicitThis() returns true

      Return values at the moment (Revision: 10884) :

      • anObj.methodCall() isImplicitThis() returns true
      • this.println("anything") isImplicitThis() returns true
      • println("anything) isImplicitThis() returns true

      patches
      ------------
      1. fix with Test

      The patch depends (only test) on the patch attached to Jira issue: http://jira.codehaus.org/browse/GROOVY-2615
      Sorry for this inconvenience

        Attachments

        1. isImplicitThisNoTest.patch
          0.7 kB
          Martin Kempf
        2. IsImplicitThisTest.patch
          3 kB
          Martin Kempf

          Issue Links

            Activity

              People

              • Assignee:
                guillaume Guillaume Sauthier
                Reporter:
                mkempf Martin Kempf
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: