[GROOVY-1862] Resource leak in ResolveVisitor.isSourceNewer()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.1-beta-1
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Aaron Digulla
• Created: 30/Apr/07 03:27
• Updated: 05/Apr/15 14:25
• Resolved: 30/Apr/07 04:19

Description

at org.codehaus.groovy.control.ResolveVisitor.isSourceNewer(ResolveVisitor.java:296) is a resource leak:

lastMod = source.openConnection().getLastModified();

The connection returned by openConnection() is never closed.

I think the solution is:

URLConnection conn = source.openConnection();
lastMod = conn.getLastModified();
conn.getInputStream.close();