[GROOVY-1855] OrderBy Comparable Check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.5.2
• Assignee: Paul King
• Reporter: Tony Lauro
• Created: 25/Apr/07 15:36
• Updated: 08/Feb/08 01:26
• Resolved: 23/Dec/07 20:49

Description

The OrderBy implemented method public int compare(Object o1, Object o2) was not accounting for Comparable equality. The code added is inside the if(value1 instanceof Comparable) clause. The original version of the code would return the value of compareTo regardless, whereas the change accounts for equality and calls continue in that case.

if (value1 instanceof Comparable) {
Comparable c1 = (Comparable) value1;
int result = c1.compareTo(value2);
if (result == 0)

{ continue; }

else

{ return result; }

}