[GROOVY-1452] GroovyEclipse should not touch the .classpath of a plugin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: James E. Ervin
• Created: 09/Aug/06 11:39
• Updated: 21/Dec/09 06:49
• Resolved: 01/Aug/07 22:50

Description

I checked out the GroovyEclipse plugin project from the subversion repository today ( 9 August 2006 ) and tried out adding the Groovy nature to the project. It almost worked perfectly, except for the curious .classpath file that was generated.

<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
<classpathentry exported="true" kind="lib" path="lib/groovy-all-1.0-JSR-06.jar"/>
<classpathentry kind="lib" path="lib/commons-io-1.2.jar"/>
<classpathentry kind="lib" path="lib/commons-lang-2.1.jar"/>
<classpathentry kind="lib" path="C:/plugins/GroovyEclipse/eclipse/plugins/org.codehaus.groovy.eclipse_1.0.0.20060725/lib/commons-io-1.2.jar"/>
<classpathentry kind="lib" path="C:/plugins/GroovyEclipse/eclipse/plugins/org.codehaus.groovy.eclipse_1.0.0.20060725/lib/commons-lang-2.1.jar"/>
<classpathentry kind="lib" path="C:/plugins/GroovyEclipse/eclipse/plugins/org.codehaus.groovy.eclipse_1.0.0.20060725/lib/groovy-all-1.0-JSR-06.jar"/>
<classpathentry kind="output" path="bin"/>
</classpath>

The problem here is, since the groovy library is already in the classpath, why add it? This kind of manipulation will not work for plugins, period. We should modify the plugin's manifest to include a dependency on Groovy Eclipse or copy the libraries into the plugin and add them to manifest and build.properties. Maybe this could include a dialog to the user to see which one they wish to use?