[GROOVY-1383] DOMBuilder class raises NPE if value is null

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0-JSR-5
• Fix Version/s: 1.1-beta-1
• Component/s: XML Processing
• Assignee: Paul King
• Reporter: Alexey Potapov
• Created: 28/Jun/06 06:55
• Updated: 04/Mar/07 01:55
• Resolved: 04/Mar/07 01:55

Description

DomBuilder.createNode() raises NPE exception if attribute value is null.
line 182 element.setAttribute(attrName, value.toString());

It's very inconveniently check every attribute for null value in script.
Exampe:
def element = xml.DOCUMENT (
ASSET: assetId == null ? "" : asset,
EXCHANGE_RATE: exchangeRate == null ? "" : exchangeRate,
...
At the same time SaxBuilder do this check
line 109 :
String valueText = (value != null) ? value.toString() : "";
I think DomBuilder.parseNode() must be done the same way. Null value must be interpreted like empty string.