Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.0-JSR-3
-
None
-
None
-
Any unix-like system
Description
The scripts groovy, groovysh, and groovyConsole all have improper line endings in the source distribution.
These are unix scripts, yet they have DOS-style line endings.
This should be fixed, either in the cvs repository or in the build process for the distribution archive.
Here's an email from the dev list concerning this issue:
On Sep 6, 2005, at 2:50 AM, Jochen Theodorou wrote:
James Berry schrieb:
I just built groovy jsr-03 from source. Three of the script files end up getting built (well, they probably just get copied over from the archive) with DOS line endings. This is no good.
it's a know issue from our cvs. I tried serveral times to change that, but without sauccess. The problem is that the windows shellscript files need a different lineending than the linux shellscript files. If you do a checkout under windows, the linux scirpts are broken, if you do a checkout under linux the dos scripts may be broken. If you now a way to ensure correct lineendings, then please tell us.
As pointed out earlier, there are distinct scripts for DOS vs unix systems, so the two can be treated separately. Too bad groovy doesn't use subversion, as it has good facilities for setting particular line-ending schemes on files. cvs is not quite so flexible: you can either tell it that the file is binary, in which case the line-endings are not adjusted, or you can tell it that the file is text, in which case they are adjusted to the line endings of the system that checks out the files.
You have at least four choices:
(1) Tell cvs that all the script files are text, and use a build process for your distro that will always set the line endings appropriately.
(2) Tell cvs that the DOS script files are binary, and always build on a unix machine.
(3) Tell cvs that the unix script files are binary, and always build on a DOS machine.
(4) Tell cvs that all the script files are binary, and check them in appropriately for each platform.