[GOSSIP-30] Use getDeadMembers instead of getDeadList

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Assignee: Rishabh Patel
• Reporter: Rishabh Patel
• Created: 17/Oct/16 19:58
• Updated: 09/Nov/16 18:03
• Resolved: 09/Nov/16 18:03

Description

The getDeadList method is a duplicate of getDeadMembers

GossipManager.java

public List<LocalGossipMember> getDeadMembers() {
    List<LocalGossipMember> down = new ArrayList<>();
    for (Entry<LocalGossipMember, GossipState> entry : members.entrySet()) {
      if (GossipState.DOWN.equals(entry.getValue())) {
        down.add(entry.getKey());
      }
    }
    return Collections.unmodifiableList(down);
  }
public List<LocalGossipMember> getDeadList() {
    List<LocalGossipMember> up = new ArrayList<>();
    for (Entry<LocalGossipMember, GossipState> entry : members.entrySet()) {
      if (GossipState.DOWN.equals(entry.getValue())) {
        up.add(entry.getKey());
      }
    }
    return Collections.unmodifiableList(up);
  }

I recommend removing getDeadList, as now we can use the pair of similarly named methods getLiveMembers and getDeadMembers

Issue Links

• links to: GitHub Pull Request #17