[GORA-526] Potential null dereference in AvroSerializer#analyzePersistent

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9
• Assignee: Madhawa Kasun Gunasekara
• Reporter: Ted Yu
• Created: 09/Sep/17 18:36
• Updated: 28/Sep/17 18:59
• Resolved: 28/Sep/17 18:59

Description

In ctor:

    if (PersistentBase.class.isAssignableFrom(dataStore.getPersistentClass())) {
      persistentSchema = ((PersistentBase) dataStore.getBeanFactory().getCachedPersistent()).getSchema();
    } else {
      persistentSchema = null;

In updateByQuery, persistentSchema is passed to CassandraQueryFactory.getUpdateByQueryForAvro() which dereferences the schema without checking:

  public boolean updateByQuery(Query query) {
    List<Object> objectArrayList = new ArrayList<>();
    String cqlQuery = CassandraQueryFactory.getUpdateByQueryForAvro(mapping, query, objectArrayList, persistentSchema);

Issue Links

• links to: GitHub Pull Request #123