[GORA-499] Potential NPE issue

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.7
• Component/s: gora-cassandra
• Assignee: JC
• Reporter: JC
• Created: 18/Dec/16 15:42
• Updated: 23/Aug/17 20:57
• Resolved: 03/Feb/17 08:35

Description

Dear Gora developers

In recent git repository, I've found the following lines in gora-cassandra/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java.

String opConsisLvl = (readOpConsLvl!=null || !readOpConsLvl.isEmpty())?readOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;
      ccl.setDefaultReadConsistencyLevel(HConsistencyLevel.valueOf(opConsisLvl));
      LOG.debug("Hector read consistency configured to '" + opConsisLvl + "'.");
      opConsisLvl = (writeOpConsLvl!=null || !writeOpConsLvl.isEmpty())?writeOpConsLvl:DEFAULT_HECTOR_CONSIS_LEVEL;

It seems, if readOpConsLvl or writeOpConsLvl is null, there could be NullPointerException as the comparison operator is "||" rather using "&&". I have no idea if this is an actual bug but just reporting. Thanks!

Issue Links

• links to: GitHub Pull Request #92