Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.2.1
    • Fix Version/s: 0.4
    • Component/s: documentation, gora-hbase
    • Labels:
      None

      Description

      Currently gora-hbase supports the following, configurable, table mapping attributes:

      • String familyName = fieldElement.getAttributeValue("name");
      • String compression = fieldElement.getAttributeValue("compression");
      • String blockCache = fieldElement.getAttributeValue("blockCache");
      • String blockSize = fieldElement.getAttributeValue("blockSize");
      • String bloomFilter = fieldElement.getAttributeValue("bloomFilter");
      • String maxVersions = fieldElement.getAttributeValue("maxVersions");
      • String timeToLive = fieldElement.getAttributeValue("timeToLive");
      • String inMemory = fieldElement.getAttributeValue("inMemory");

      We do not make this explicit therefore we should not be surprised if no-one seems to know about these.

      This issue should add default values for these values to all existing gora-hbase-mapping.xml files and should also document their use, case and effect within the gora-hbase documentation.

      1. GORA-218.patch
        2 kB
        Lewis John McGibbney

        Activity

        Hide
        Lewis John McGibbney added a comment -

        This is a trivial patch for trunk which merely adds in some bog standard debug logging for hbase table mapping attributes and values.
        What I want (but admittedly don't know) is what default values are good to set within the gora-hbase-mapping.xml used within the tests?
        Can someone more HBase literate please help out here?
        The idea would be to document such optional attributes somewhere and also to have them within the test mapping file so that this can act as a resource for best sensible practice.

        Show
        Lewis John McGibbney added a comment - This is a trivial patch for trunk which merely adds in some bog standard debug logging for hbase table mapping attributes and values. What I want (but admittedly don't know) is what default values are good to set within the gora-hbase-mapping.xml used within the tests? Can someone more HBase literate please help out here? The idea would be to document such optional attributes somewhere and also to have them within the test mapping file so that this can act as a resource for best sensible practice.
        Hide
        Lewis John McGibbney added a comment -

        Is this really required?

        Show
        Lewis John McGibbney added a comment - Is this really required?
        Hide
        Henry Saputra added a comment -
        Show
        Henry Saputra added a comment - CC Enis Soztutar ?
        Hide
        Enis Soztutar added a comment -

        Of course some of these values are use case specific. I don't think we need to set these for tests, unless we are testing the actual logic of setting stuff.

        Aren't these already documented here: http://gora.apache.org/current/gora-hbase.html ?

        BTW, none of the links in the web site work, do you guys know what is up with that?

        Show
        Enis Soztutar added a comment - Of course some of these values are use case specific. I don't think we need to set these for tests, unless we are testing the actual logic of setting stuff. Aren't these already documented here: http://gora.apache.org/current/gora-hbase.html ? BTW, none of the links in the web site work, do you guys know what is up with that?
        Hide
        Henry Saputra added a comment -

        Hi Enis, which links that do not work? The one you put seems to work, and other links from website.

        Show
        Henry Saputra added a comment - Hi Enis, which links that do not work? The one you put seems to work, and other links from website.
        Hide
        Enis Soztutar added a comment -

        Hi Enis, which links that do not work? The one you put seems to work, and other links from website.

        Thanks Henry for checking. it seems that when you go gora.apache.org, it seems ok. I was checking https://gora.apache.org/current/tutorial.html#, and the links there dont work.

        Show
        Enis Soztutar added a comment - Hi Enis, which links that do not work? The one you put seems to work, and other links from website. Thanks Henry for checking. it seems that when you go gora.apache.org, it seems ok. I was checking https://gora.apache.org/current/tutorial.html# , and the links there dont work.
        Hide
        Lewis John McGibbney added a comment -

        Thanks Henry for checking. it seems that when you go gora.apache.org, it seems ok. I was checking https://gora.apache.org/current/tutorial.html#, and the links there dont work.

        I just pushed a fix for this Enis Soztutar so when the site builds we will be good with the links.

        So, just to clarify, all HBase table mapping attributes are documented at http://gora.apache.org/current/gora-hbase.html
        The attached patch merely adds debug logging to table mappings. I wondered if this was necessary/useful if users are analyzing logs?

        Show
        Lewis John McGibbney added a comment - Thanks Henry for checking. it seems that when you go gora.apache.org, it seems ok. I was checking https://gora.apache.org/current/tutorial.html# , and the links there dont work. I just pushed a fix for this Enis Soztutar so when the site builds we will be good with the links. So, just to clarify, all HBase table mapping attributes are documented at http://gora.apache.org/current/gora-hbase.html The attached patch merely adds debug logging to table mappings. I wondered if this was necessary/useful if users are analyzing logs?
        Hide
        Enis Soztutar added a comment -

        I think this debug is useful, but will this be executed on every mapping creation, or just for create table. If you are just using the table (rather than creating), this logging maybe too much. For create table, it is good to log everything in the table description.

        Show
        Enis Soztutar added a comment - I think this debug is useful, but will this be executed on every mapping creation, or just for create table. If you are just using the table (rather than creating), this logging maybe too much. For create table, it is good to log everything in the table description.
        Hide
        Lewis John McGibbney added a comment -

        but will this be executed on every mapping creation

        Yes, this is why I think it is too verbose!
        I think we can close as invalid ?

        Show
        Lewis John McGibbney added a comment - but will this be executed on every mapping creation Yes, this is why I think it is too verbose! I think we can close as invalid ?
        Hide
        Enis Soztutar added a comment -

        ok.

        Show
        Enis Soztutar added a comment - ok.
        Hide
        Lewis John McGibbney added a comment -

        OK Enis Soztutar I will close this as mapping per table is too much.
        If you wish to revert (or anyone else) please do.
        Thanks Enis Soztutar

        Show
        Lewis John McGibbney added a comment - OK Enis Soztutar I will close this as mapping per table is too much. If you wish to revert (or anyone else) please do. Thanks Enis Soztutar
        Hide
        Lewis John McGibbney added a comment - - edited

        Not required. The logging is TOO verbose for every reading mapping instance. Documentation is on the Gora site folks.

        http://gora.apache.org/current/gora-hbase.html

        Show
        Lewis John McGibbney added a comment - - edited Not required. The logging is TOO verbose for every reading mapping instance. Documentation is on the Gora site folks. http://gora.apache.org/current/gora-hbase.html

          People

          • Assignee:
            Lewis John McGibbney
            Reporter:
            Lewis John McGibbney
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development