Apache Gora
  1. Apache Gora
  2. GORA-127

Result objects are not closed properly from GoraRecordReader

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2.1
    • Component/s: None
    • Labels:
      None

      Description

      This was first reported by Stack using goraci. After the changes for GORA-23, GoraRecordReader does it's own sharding on top of the split, but the query result objects, except for the last one, are not closed properly. We should ensure we are closing the result objects, so that the underlying server resources are released.

      Patch coming up shortly.

      1. gora-127_v1.patch
        0.9 kB
        Enis Soztutar

        Activity

        Enis Soztutar created issue -
        Enis Soztutar made changes -
        Field Original Value New Value
        Assignee Enis Soztutar [ enis ]
        Hide
        Enis Soztutar added a comment -

        Simple patch attached.

        Show
        Enis Soztutar added a comment - Simple patch attached.
        Enis Soztutar made changes -
        Attachment gora-127_v1.patch [ 12526089 ]
        Hide
        Ferdy Galema added a comment -

        Patch looks good. +1

        Show
        Ferdy Galema added a comment - Patch looks good. +1
        Hide
        Enis Soztutar added a comment -

        Committed to trunk. Thanks Ferdy for the review.

        Show
        Enis Soztutar added a comment - Committed to trunk. Thanks Ferdy for the review.
        Enis Soztutar made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.3 [ 12317954 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in gora-trunk #265 (See https://builds.apache.org/job/gora-trunk/265/)
        GORA-127 Result objects are not closed properly from GoraRecordReader (Revision 1336389)

        Result = SUCCESS
        enis :
        Files :

        • /gora/trunk/CHANGES.txt
        • /gora/trunk/gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordReader.java
        Show
        Hudson added a comment - Integrated in gora-trunk #265 (See https://builds.apache.org/job/gora-trunk/265/ ) GORA-127 Result objects are not closed properly from GoraRecordReader (Revision 1336389) Result = SUCCESS enis : Files : /gora/trunk/CHANGES.txt /gora/trunk/gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordReader.java
        Lewis John McGibbney made changes -
        Fix Version/s 0.2.1 [ 12322496 ]
        Fix Version/s 0.3 [ 12317954 ]
        Lewis John McGibbney made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Workflow jira [ 12666502 ] no-reopen-closed, patch-avail [ 12735300 ]
        Hide
        Hudson added a comment -

        Integrated in goraOracle #6 (See https://builds.apache.org/job/goraOracle/6/)
        GORA-127 Result objects are not closed properly from GoraRecordReader (Revision bf010f26487edbfdfd79588df01fe5c9458ca40b)

        Result = FAILURE
        enis :
        Files :

        • CHANGES.txt
        • gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordReader.java
        Show
        Hudson added a comment - Integrated in goraOracle #6 (See https://builds.apache.org/job/goraOracle/6/ ) GORA-127 Result objects are not closed properly from GoraRecordReader (Revision bf010f26487edbfdfd79588df01fe5c9458ca40b) Result = FAILURE enis : Files : CHANGES.txt gora-core/src/main/java/org/apache/gora/mapreduce/GoraRecordReader.java

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development