Uploaded image for project: 'Apache Gora'
  1. Apache Gora
  2. GORA-120

Dirty fields are not correctly applied after serialization and map clearance

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2
    • Component/s: None
    • Labels:
      None

      Description

      Dirty fields are not correctly applied in these situations:

      -All entries in the map are incorrectly made dirty when a Persistent is deserialized.
      -Also, due to a separate bug all non-map entries that are deserialized are made dirty too. (This is pure coincidence as the bugs have different causes).
      -Finally, when a map is cleared but some entries that are put afterwards are actually the same as before, it should be noticed as non-dirty. (This happens in Nutchgora a lot: getInlinks.clear(), getOutlinks.clear(), getHeaders.clear() etc.).

      Because of this a lot of fields are dirty when they in fact are not. It is never the other way around. Therefore, this bug purely affects performance.

      Patch will follow shortly. Let me know if you have any comments.

        Attachments

        1. GORA-120-v1.txt
          7 kB
          Ferdy

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ferdy.g Ferdy
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: