[GOBBLIN-73] WriterInitializerFactory should not depend on JdbcWriterBuilder or JdbcWriterCommandsFactory

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: Core:Writer Writer:JDBC enhancement
• External issue URL: https://github.com/linkedin/gobblin/issues/1432
• Assignee: Unassigned
• Reporter: Shirshanka Das
• Created: 19/Jul/17 07:39
• Updated: 07/Aug/17 17:51

Description

gobblin.writer.initializer.WriterInitializerFactory seems to depend explicitly on JDBC classes.

if(JdbcWriterBuilder.class.getName().equals(writerBuilderClass))

{ return new JdbcWriterInitializer(state, workUnits, new JdbcWriterCommandsFactory(), branches, branchId); }

@jinhyukchang : Can you propose a way to break this dependency?

Also, this class should probably move to gobblin-runtime as I don't see any other class (other than AbstractJobLauncher) depending on this class.

Github Url : https://github.com/linkedin/gobblin/issues/1432
Github Reporter : shirshanka
Github Assignee : shirshanka
Github Created At : 2016-12-05T05:20:22Z
Github Updated At : 2017-01-12T04:17:23Z

Comments

---

jinhyukchang wrote on 2016-12-05T17:49:03Z : Hi @shirshanka ,

I think we can make DataWriterBuilder provide its WriterInitializer where by default it will provide NO-OP writer initializer and JdbcWriterBuilder provides its own by overriding it. This will make it more generic and it makes sense to move it to gobblin-runtime.

Thoughts?

Github Url : https://github.com/linkedin/gobblin/issues/1432#issuecomment-264924214