[GOBBLIN-158] consider migrating Gobblin JDBC adapters to a SQL builder library

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: Source:JDBC Writer:JDBC enhancement help wanted
• External issue URL: https://github.com/linkedin/gobblin/issues/236
• Assignee: Unassigned
• Reporter: Abhishek Tiwari
• Created: 19/Jul/17 07:40
• Updated: 19/Jul/17 07:40

Description

Currently gobblin uses rather error-prone string handling to generating SQL queries. We should consider migrating to a more robust SQL builder library like Jooq (www.jooq.org) or querydsl (www.querydsl.com).

Github Url : https://github.com/linkedin/gobblin/issues/236
Github Reporter : chavdar
Github Created At : 2015-07-20T17:07:49Z
Github Updated At : 2017-01-12T04:28:44Z

Comments

---

stakiar wrote on 2016-02-05T21:08:18Z : Jooq 3.7+ seems to require Java 8 (https://groups.google.com/forum/#!topic/jooq-user/90ggBTGl2y0), but version 3.6.4 should work.

The current `JDBCExtractor` converts a `ResultSet` into a GSON `JsonElement`. It would be more flexible to just return a `ResultSet` and have converts for `ResultSetToJson` and `ResultSetToAvro`.

The `JDBCExtractor` should probably not be an abstract class, so it can provide some default implementation for arbitrary JDBC adapters.

Github Url : https://github.com/linkedin/gobblin/issues/236#issuecomment-180554380