Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-911

Calling setConf on wrapped Input and Output classses.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Invalid
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:

      Description

      There is a set of wrappers for vertex and edge input and output format classes that create a copy of the class and then calls certain methods using a modified context. The wrapped class is configurable, but setConf is never called on it. If a user creates their own vertex or edge input or output format that requires some special set-up, they cannot rely on the the setConf call to achieve this in all situations; it will work for unwrapped instances of the class but not for the wrapped class.

      Thus for the wrapped classes there should be a setConf method that calls the super for the wrapper as well as setConf on the wrapped class.

        Attachments

        1. GIRAPH-911.patch
          3 kB
          Tom Schweiger

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              starkadder Tom Schweiger
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified