Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-891

Make MessageStoreFactory configurable

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: bsp
    • Labels:
      None

      Description

      As mentioned in the task: 4213037

      Related to the Task: https://our.intern.facebook.com/intern/tasks/?s=754080093&t=4213037

      Changed the MessageStoreFactory interface and added a new method "initialize(service, config)" in order to do the setting up of message store factory. In order to invoke the class (as per the configuration) on run time, reflection is used for the class invocation and then initialize() method is called on the instance.

      There were few classes which had private factory implementation, for these classes there is no need to implement the initialize() method as the class is never exposed and can't be passed as a configuration.

      Also, in order to make the DiskBackedMessageStore.class value to be passed from the configuration, I moved the implementation to the new file and made this class as a public class.

      Modified a test case for testing this configuration(DiskBased/InMemory Backed Message Stores).

      Review Link: https://reviews.apache.org/r/20915/

        Attachments

        1. diff_2ndmay.txt
          33 kB
          Rohan Karwa

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rohankarwa Rohan Karwa
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: