Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-835

org.apache.giraph.hive.input.CheckInputTest Fails because JobProgressTracker doesn't check null

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: graph
    • Labels:
      None

      Description

      org.apache.giraph.hive.input.CheckInputTest Fails because JobProgressTracker doesn't check null string returned from CounterUtils.waitAndGetCounterNameFromGroup()

      -------------------------------------------------------------------------------
      Test set: org.apache.giraph.hive.input.CheckInputTest
      -------------------------------------------------------------------------------
      Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 35.864 sec <<< FAILURE!
      testCheckJobThrows(org.apache.giraph.hive.input.CheckInputTest) Time elapsed: 15.001 sec <<< ERROR!
      java.lang.NullPointerException
      at org.apache.zookeeper.ClientCnxn.<init>(ClientCnxn.java:360)
      at org.apache.zookeeper.ClientCnxn.<init>(ClientCnxn.java:331)
      at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:377)
      at org.apache.giraph.zk.ZooKeeperExt.<init>(ZooKeeperExt.java:114)
      at org.apache.giraph.job.JobProgressTracker.<init>(JobProgressTracker.java:69)
      at org.apache.giraph.job.GiraphJob.run(GiraphJob.java:255)
      at org.apache.giraph.utils.InternalVertexRunner.run(InternalVertexRunner.java:178)
      at org.apache.giraph.hive.input.CheckInputTest.testCheckJobThrows(CheckInputTest.java:113)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:606)
      at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
      at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
      at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
      at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
      at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
      at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
      at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
      at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
      at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
      at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
      at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
      at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120)
      at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103)
      at org.apache.maven.surefire.Surefire.run(Surefire.java:169)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:606)
      at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
      at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)

        Attachments

        1. GIRAPH-835.patch
          5 kB
          Akila Wajirasena

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              akilaw Akila Wajirasena
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: