Giraph
  1. Giraph
  2. GIRAPH-75

Create sections on how to get involved and how to generate patches on website

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: None
    • Labels:
      None

      Description

      We've had several questions lately on how to get started. It would be good to document this on the site.

      1. GIRAPH-75-2.patch
        6 kB
        Jakob Homan
      2. GIRAPH-75.patch
        6 kB
        Jakob Homan

        Activity

        Jakob Homan created issue -
        Hide
        Jakob Homan added a comment -

        Patch that adds these sections. It's a big enough change to get another set of eyes on. Since I wrote it, it's heavily weighted toward my style of developing, but I don't think it's too far outside the mainstream. I didn't even say anything mean about rb.

        Show
        Jakob Homan added a comment - Patch that adds these sections. It's a big enough change to get another set of eyes on. Since I wrote it, it's heavily weighted toward my style of developing, but I don't think it's too far outside the mainstream. I didn't even say anything mean about rb.
        Jakob Homan made changes -
        Field Original Value New Value
        Attachment GIRAPH-75.patch [ 12503411 ]
        Jakob Homan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Claudio Martella added a comment -

        Looks very informative to me.

        Just two things:

        1) I'd personally add about the delay/unsync between github and apache svn, it can create quite a complication.

        2) A link to reviewboard where it's mentioned? Another line just elaborating it gives the possibility to get per-line feedback?

        Show
        Claudio Martella added a comment - Looks very informative to me. Just two things: 1) I'd personally add about the delay/unsync between github and apache svn, it can create quite a complication. 2) A link to reviewboard where it's mentioned? Another line just elaborating it gives the possibility to get per-line feedback?
        Hide
        Hyunsik Choi added a comment -

        +1

        The patch contains very informative for newbies of Giraph.

        I would like to give a suggestion.
        The index page is likely to include a mix of various contents.
        How about making a separate page for these sections?

        Show
        Hyunsik Choi added a comment - +1 The patch contains very informative for newbies of Giraph. I would like to give a suggestion. The index page is likely to include a mix of various contents. How about making a separate page for these sections?
        Hide
        Jakob Homan added a comment -

        Updated patch based on Claudio's feedback. Will commit this.

        Show
        Jakob Homan added a comment - Updated patch based on Claudio's feedback. Will commit this.
        Jakob Homan made changes -
        Attachment GIRAPH-75-2.patch [ 12503560 ]
        Hide
        Jakob Homan added a comment -

        I've committed this. Resolving. Thanks for the reviews!

        Show
        Jakob Homan added a comment - I've committed this. Resolving. Thanks for the reviews!
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.70.0 [ 12317572 ]
        Resolution Fixed [ 1 ]
        Hide
        Jakob Homan added a comment -

        How about making a separate page for these sections?

        Sounds good. I'll comment on GIRAPH-79.

        Show
        Jakob Homan added a comment - How about making a separate page for these sections? Sounds good. I'll comment on GIRAPH-79 .
        Hide
        Hudson added a comment -

        Integrated in Giraph-trunk-Commit #28 (See https://builds.apache.org/job/Giraph-trunk-Commit/28/)
        GIRAPH-75. Create sections on how to get involved and how to generate patches on website.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201596
        Files :

        • /incubator/giraph/trunk/CHANGELOG
        • /incubator/giraph/trunk/src/site/xdoc/index.xml
        Show
        Hudson added a comment - Integrated in Giraph-trunk-Commit #28 (See https://builds.apache.org/job/Giraph-trunk-Commit/28/ ) GIRAPH-75 . Create sections on how to get involved and how to generate patches on website. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1201596 Files : /incubator/giraph/trunk/CHANGELOG /incubator/giraph/trunk/src/site/xdoc/index.xml

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development