Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-743

DiskBackedPartitionStore needs file existence checks around file deletion and directory creation

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: graph
    • Labels:

      Description

      The changes made to DiskBackedPartitionStore with GIRAPH-736 introduced return code checks on File.delete() and File.mkdirs() calls, and if they are unsuccessful it is logged as an ERROR. This really only makes sense if the file already exists or the directory doesn't exist respectively. In addition to these checks, the ERROR messages that are logged should use the absolute file path instead of the relative path.

        Attachments

        1. GIRAPH-743.patch
          3 kB
          Craig Muchinsky

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                cmuchinsky@initiatesystems.com Craig Muchinsky
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: