Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-595

InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      The current way GiraphClasses is used is not ideal for two reasons:
      1) InternalVertexRunner has to add all those wrapper calls like conf.setXXXClass(classes.getXXXClass()). This is verbose and fragile since it has to be updated every time we add a new type of class.
      2) The configuration flow is circular: the user creates a GiraphClasses, which is used to create GiraphConfiguration, which is used to create ImmutableClassesGiraphConfiguration, which creates a new GiraphClasses!

      https://reviews.apache.org/r/10387/

      Attachments

        1. GIRAPH-595.patch
          54 kB
          Nitay Joffe
        2. GIRAPH-595.patch
          107 kB
          Alessandro Presta

        Issue Links

          blocks

          Task - A task that needs to be done. GIRAPH-285 Release Giraph-1.0

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              nitay Nitay Joffe
              apresta Alessandro Presta
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: