Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-576

BspServiceMaster.failureCleanup() shouldn't pass null in observers' applicationFailed() method

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1.0.0
    • Component/s: bsp
    • Labels:
    • Environment:

      Linux

      Description

      failureCleanup() in BspServiceMaster gets called with a null exception from failJob(). That in turn passes a null exception to the set of MasterObservers, in their applicationFailed() method. They probably aren't expecting that. Instead we should pass an appropriate exception around depending on the cause of the failure.

      I'll attach a patch.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jessgarms Jess Garms
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified