Uploaded image for project: 'Giraph'
  1. Giraph
  2. GIRAPH-55

BasicRPCCommunications shouldn't implement both CommunicationsInterface and ServiceInterface

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Invalid
    • None
    • None
    • None
    • None

    Description

      Currently, BasicRPCCommunications, the base class for RPC in a worker, implements both the server interface and the proxy-to-other-workers interface. It would be much easier to test and refactor if these responsibilities were divided into two different classes and the RPCCommunications merged interface went away.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jghoman Jakob Homan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: